Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413?usp=email ) Change subject: mme: Trigger last parts of procedure TC_ue_cell_reselect_eutran_to_geran ...................................................................... Patch Set 1: (3 comments) File mme/MME_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413/comment/015bdd32_0436e... PS1, Line 668: S1AP.receive(PDU_NAS_EPS:?) -> value rx_nas
Having such a generic 'catch-all' case makes the altstep less flexible. […] ACK, but that's not a problem right now, and it helps/speeds up development/testing which is the main purpose right now. If somebody ever requires to reuse the altstep then it can be modified/refactored.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413/comment/4b948965_2fa3a... PS1, Line 840: var BearerContextIEs rx_bctx_ies; : var template (value) FullyQualifiedTEID s11_fteid_c_ie, s11_fteid_u_ie, s5c_fteid_c_ie, s5c_fteid_u_ie; : var template (value) BearerContextIEs bctx_ies;
all unused? Could be, I'll have a look.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413/comment/01c39d8c_19683... PS1, Line 850: GTP2.receive
Likewise, this catch-everything makes it more a single-purpose function rather than a generic altste […] same as other comment.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic0263a3aec922194aad22b031b2c82a99954354d Gerrit-Change-Number: 35413 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jan 2024 11:55:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment