Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email )
Change subject: Add Cisco like DSCP configuration support ......................................................................
Patch Set 3:
(8 comments)
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/c85e9948_c46af5... : PS1, Line 423: asp->cfg.ip_dscp = 0;
You were mentioning in the ticket OS#6753: […]
Ok fine, but since here you are resetting ip_dscp, I think it's a good idea to if (asp->cfg.ip_dscp > 0) vty_out(""%% Config updated: ip-dscp %d => qos-class %d") or similar.
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/1be699d6_c7db17... : PS3, Line 440: ss7_asp_apply_ip_dscp(asp); btw, it may make sense to rename this "ss7_asp_apply_ip_dscp" into "ss7_asp_apply_qos_class()"
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/df4af1c3_87774b... : PS3, Line 467: Better keep the qos-class commands in this place rather than above, to follow the order in ss7_vty_init_node_asp().
It actually makes sense that qos-class comes *after* ip-dscp since qos-class replaces ip-dscp.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/9521dc0c_94399f... : PS3, Line 1458: if (asp->cfg.ip_dscp != 0) you can use "else if" here, to denote explicitly that ip-dscp can only be >0 if qos_class is not set.
File src/ss7_xua_srv.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/6d0f98ec_28ad2f... : PS3, Line 417: else logic changed here, missing "if (xs->cfg.ip_dscp != 0)". Either a bug in this commit, or something worth submitting in a previous commit.
File src/ss7_xua_srv_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/0c4faff3_8e47dd... : PS3, Line 152: DEFUN_ATTR(xua_qos_class, xua_qos_class_cmd, Move these further below to match ss7_vty_init_node_oxs() order.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/07a24d1e_f974fc... : PS3, Line 289: if (xs->cfg.ip_dscp) else if
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/5b234b38_e75e5e... : PS3, Line 407: install_lib_element(L_CS7_XUA_NODE, &xua_qos_class_cmd); Move this below init_ip_dscp, as in the asp vty case.