Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email ) Change subject: osmo-bts-trx: apply 'max-initial' value before POWERON ...................................................................... Patch Set 2: (6 comments) This change is ready for review. File src/osmo-bts-trx/trx_provision_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/0b587747_46f50441?usp=... : PS1, Line 180: bts_model_change_power(pinst->trx, initial_mdBm);
AFAIU this calls get_p_max_out_mdBm(), which relies on knowing the nominal power of the device, whic […] Acknowledged
https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/3e42d997_ac670808?usp=... : PS1, Line 222: return 0;
I guess you should do something like this here? […] Done
https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/ea30ec61_bf3daa58?usp=... : PS1, Line 271: (l1h->config.setformat_acked)) {
l1h->config.setformat_acked && […] Done
https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/0e8f0d2e_6495025a?usp=... : PS1, Line 463: l1if_trx_set_nominal_power(trx, nominal_power);
See how nominal power is set here. Done
https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/7de5acc2_fb2b6573?usp=... : PS1, Line 491: case TRX_PROV_EV_OTHER_TRX_READY:
case TRX_PROV_EV_INITIAL_SETPOWER: […] Done
https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/866922cf_40ba39a3?usp=... : PS1, Line 529: );
l1h->config. […] Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff03d4dcb74f67629a59c8d6f8bb60929d9f6ddd Gerrit-Change-Number: 42033 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 12:32:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>