Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31062 ) Change subject: Introduce netdev API ...................................................................... Patch Set 2: (2 comments) File src/core/netdev.c: https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/782a2aef_0af874ed PS2, Line 703: /
this might be interpreted in a way that one can set/change the ifindex of the actual kernel network […] I will improve the documentation.
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/0344c954_d694eb58 PS2, Line 720: unsigned
if we used a signed int for ifindex, we could return a negative error value here if no ifindex was s […] 0 seems to be an "unused"/"reserved" ifindex according to if_nametoindex return value. Also "ip l" shows no interface with ifindex=0. I Will add an "#define IFINDEX_UNSET 0" in the header in case it's more descriptive.
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a00c0445a89e088676a4897061b65196d9197f1 Gerrit-Change-Number: 31062 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Tue, 24 Jan 2023 17:48:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment