Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37412?usp=email ) Change subject: deps/Makefile: Use osmocom fork of titan.TestPorts.SIPmsg ...................................................................... Patch Set 1: (1 comment) File deps/Makefile: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37412/comment/5389001e_2da5f... PS1, Line 132: titan.TestPorts.SIPmsg_commit= osmocom/master I suggest using a specific commit here, like in the other lines. Otherwise it's not clear which commit is used at which time, which makes reproducing errors and bisect harder. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37412?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If9bffd57204ee1ea56cbf0cb0109c422fb2c460f Gerrit-Change-Number: 37412 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jul 2024 08:22:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment