Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32630 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/43370faf_dc1cddbf PS3, Line 1949: static struct msgb *rtppayload_convert_hr(const uint8_t *rtp_pl, uint8_t rtp_pl_len, struct gsm_lchan *lchan) This looks much clearer now, thanks! Maybe add a comment somewhere that packets with rtp_pl_len different than GSM_HR_BYTES_RTP_TS101318 or GSM_HR_BYTES_RTP_RFC5993 have already been filtered out in previous code paths here. Maybe even use a switch (rtp_pl_len) and OSMO_ASSERT(0) in default branch.