Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email )
Change subject: trxcon/trx_if: migrate to libosmo-trx
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/437b18aa_5e386d04?us... :
PS1, Line 484: const struct trxcon_phyif_burst_ind phybi = {
No. PHYIF is an abstract interface of libtrxcon and exists for a reason. […]
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/6adda5d6_5cbc9c4e?us... :
PS1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff);
Not sure what you mean by "explicitly". […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I4604f4b12ca903e936dedf167b478455bd28a2e8
Gerrit-Change-Number: 43828
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 09 Oct 2026 20:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
