Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33768 ) Change subject: bts: send IMMEDIATE ASSIGNMENT via AGCH when no IMSI is available ...................................................................... Patch Set 1: Code-Review-1 (5 comments) Patchset: PS1: This cannot be merged until we confirm the ImmAss on AGCH back to PCU. This is going to be useful for UL TBF Imm Ass too. File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/33768/comment/ab0cbb75_a67af607 PS1, Line 1126: if (strlen(tbf->imsi()) < 3) { ms_imsi_is_valid() https://gerrit.osmocom.org/c/osmo-pcu/+/33768/comment/4f5fd918_0aae50ba PS1, Line 1127: /* In case the IMSI is not yet known, the IMMEDIATE ASSIGNMENT is sent on the AGCH. The reason Maybe explain that the usual case around here is during GMM attach, where the SGSN still didn't learn the IMSI of the subscriber (through Id Request) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/33768/comment/5e6012b4_6876463c PS1, Line 278: /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX imsi_len = strlen(imsi); OSMO_ASSERT (imsi_len > 0); https://gerrit.osmocom.org/c/osmo-pcu/+/33768/comment/34ad65a3_c9a27cfe PS1, Line 310: /* OS#6097: if strlen(pch_dt.imsi) == 0: We assume the MS is in non-DRX Same as above. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iae1dd5d6be9ee8813a9c0b092926e8eda63f1e8e Gerrit-Change-Number: 33768 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 13:50:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment