pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27289 ) Change subject: BSSGP_Emulation: usse alive-type for internal BVC created components ...................................................................... BSSGP_Emulation: usse alive-type for internal BVC created components Otherwise, during shutdown of all components we may end up in a situation where the BVC is already killed and BSSGP Emulation receives a packet which tries to forward to BVC and fails. This can be seen quite a lot in PCU_Tests.TC_pcuif_suspend: """ PCU_Tests.ttcn:394 setverdict(pass): none -> pass ... PCUIF_Components.ttcn:246 Stopping test component execution. ... GPRS_Components.ttcn:222 Connection of port BSSGP[0] to TC_pcuif_suspend-BVCI1234(6):BSSGP_SP was closed unexpectedly by the peer. ... GPRS_Components.ttcn:222 Port BSSGP[0] was disconnected from TC_pcuif_suspend-BVCI1234(6):BSSGP_SP. ... Component type BSSGP_Emulation.BSSGP_BVC_CT was shut down inside testcase TC_pcuif_suspend ... BSSGP_Emulation.ttcnpp:317 Dynamic test case error: Sending data on the connection of port BVC to 6:BVC failed. (Broken pipe) """ Change-Id: Ib0adcf64eb5ca876cd9e9b91f2b597804c03bdc2 --- M library/BSSGP_Emulation.ttcnpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp index e0b5dee..1b628b3 100644 --- a/library/BSSGP_Emulation.ttcnpp +++ b/library/BSSGP_Emulation.ttcnpp @@ -198,7 +198,7 @@ var BssgpBvcConfig bvc_cfg := g_cfg.bvc[i]; var charstring bvc_id := id & "-BVCI" & int2str(bvc_cfg.bvci); /* create, connect and start the BVC component */ - var BSSGP_BVC_CT bvc_ct := BSSGP_BVC_CT.create(bvc_id); + var BSSGP_BVC_CT bvc_ct := BSSGP_BVC_CT.create(bvc_id) alive; connect(bvc_ct:BVC, self:BVC); bvc_ct.start(f_bssgp_bvc_main(bvc_cfg, g_cfg.sgsn_role, g_cfg.nsei, bvc_id)); /* populate the BVC state table */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib0adcf64eb5ca876cd9e9b91f2b597804c03bdc2 Gerrit-Change-Number: 27289 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged