Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email )
Change subject: tests: improve test infrastructure to support multiple test vectors ......................................................................
Patch Set 2:
(3 comments)
File tests/parse/tcap_parse_test.c:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/fac260d0_17a2... : PS2, Line 18: #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
we have an OSMO_ define for this already in libosmocore. […]
No, it doesn't depend on any other libraries, not even libosmocore
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/43327a83_72b9... : PS2, Line 30: static const unsigned char pkt_begin[] = {0x62, 0x06, 0x48, 0x04, 0x00, 0x01, 0x02, 0x03};
Can you please put in the file as a comment the decoded tree by wireshark?
Acknowledged
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/41dfdbaa_7a17... : PS2, Line 55: printf("Broken encoding %u at byte %lu\n", rc.code, rc.consumed);
broken decoding?
Acknowledged