Attention is currently required from: laforge, neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40209?usp=email )
Change subject: personalization audit: optionally audit all (unknown) SD keys ......................................................................
Patch Set 10:
(1 comment)
File pySim/esim/saip/batch.py:
https://gerrit.osmocom.org/c/pysim/+/40209/comment/5a55c6ed_0dac2a2b?usp=ema... : PS10, Line 186: upp_audit[audit_key] = set((audit_val, )) Is it possible that the same KVN/ID combination appears in more than one SD PE? If so, the second occurrence silently replaces the first. We could handle this gracefully:
```suggestion upp_audit.add_values({audit_key: audit_val}) ```