dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43850?usp=email )
(
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: esipa_Types_JSON: make eimAcknowledgements mandatory ......................................................................
esipa_Types_JSON: make eimAcknowledgements mandatory
The JSON type JSON_ESipa_ProvideEimPackageResultResponse has only one optional member eimAcknowledgements (next to the mandatory header field, that all message types have in common). In case the eimAcknowledgements member is missing. The JSON_ESipa_ProvideEimPackageResultResponse becomes indistinguishable from JSON_ESipa_EmptyResponse. To make it distinguishable, let's make the eimAcknowledgements mandatory. So that when it is included, the decoder will decode the message as JSON_ESipa_ProvideEimPackageResultResponse and as JSON_ESipa_EmptyResponse otherwise. It is then up to the API user to interpret the response accordingly.
Change-Id: I8e151d7570ee9c3293340a5f8e52cfc62c60a018 Related: SYS#8203 --- M library/euicc/esipa_Types_JSON.ttcn 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: jolly: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified
diff --git a/library/euicc/esipa_Types_JSON.ttcn b/library/euicc/esipa_Types_JSON.ttcn index 6d027b5..ab9c420 100644 --- a/library/euicc/esipa_Types_JSON.ttcn +++ b/library/euicc/esipa_Types_JSON.ttcn @@ -116,7 +116,7 @@ }; type record JSON_ESipa_ProvideEimPackageResultResponse { JSON_ESx_ResponseHeader header, - charstring eimAcknowledgements optional + charstring eimAcknowledgements /* required to distinct from JSON_ESipa_EmptyResponse */ };
/* GSMA SGP.32, section 6.4.1.7 */