Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43106?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: libosmo-trx/trxc: enlarge the params buffer ...................................................................... libosmo-trx/trxc: enlarge the params buffer The SETFH command (implemented by trxcon and fake_trx) carries the whole Mobile Allocation as pairs of Rx/Tx frequencies in kHz: CMD SETFH <HSN> <MAIO> <RXF1> <TXF1> [... <RXFN> <TXFN>] With up to 64 ARFCNs in the Mobile Allocation, the parameters string alone can exceed 1000 characters, far beyond the old 128 byte limit. Derive OSMO_TRXC_PARAMS_LEN_MAX from OSMO_TRXC_MSG_BUF_SIZE, so that any message ("RSP " + verb + status + params) still fits the recommended socket buffer size. Also add the OSMO_TRXC_CMD_SETFH verb constant and a regression test doing a round-trip of a maximum size SETFH command (64 ARFCNs). Change-Id: I2f65b213f5ada499eea4abae87d3727057e03e22 --- M libosmo-trx/include/osmocom/trx/trxc.h M tests/libosmo-trx/trxc_test.c M tests/libosmo-trx/trxc_test.ok 3 files changed, 57 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/06/43106/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2f65b213f5ada499eea4abae87d3727057e03e22 Gerrit-Change-Number: 43106 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>