Attention is currently required from: jolly, lynxis lazus.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email )
Change subject: Add maintenance mapping support to osmo-remsim-server
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/server/rest_api.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/75db6f00_fae6d85a?u... :
PS4, Line 287: maintenance = (maintenance_str && !strcmp(maintenance_str, "true"));
should this 'true' be case-sensitive?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I885b3b529276f46fbbe6d86be2170b0bffbb8434
Gerrit-Change-Number: 43745
Gerrit-PatchSet: 4
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Fri, 09 Oct 2026 11:56:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes