Attention is currently required from: arehbein, laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33194 ) Change subject: examples: Use new stream API in {ipa-,}stream-{client,server} ...................................................................... Patch Set 13: (5 comments) File examples/ipa-stream-client.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/45896c94_ace4aeac PS1, Line 161: LOGL_DEBUG
unrelated change Ack
File examples/ipa-stream-client.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/99c13bde_5e3e49e0 PS13, Line 167: conn = osmo_stream_cli_create2(tall_test, "ipa test client"); underscores instead of spaces? We'll end up logging that name at some point, spaces are not nice as ids usually. File examples/ipa-stream-server.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/0beb35f5_faab2999 PS13, Line 78: conn = osmo_stream_srv_create2(tall_test, "srv link", srv, fd, NULL); same, no spaces in name? File examples/stream-client.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/47c0dfe3_54c72969 PS13, Line 107: conn = osmo_stream_cli_create2(tall_test, "stream client"); no spaces in name. File examples/stream-server.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/635d9edc_83837b22 PS13, Line 72: conn = osmo_stream_srv_create2(tall_test, "stream server", srv, fd, NULL); no spaces in mame. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I97a9979199c816686b32080534627f6f033e009e Gerrit-Change-Number: 33194 Gerrit-PatchSet: 13 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 16:05:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment