Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email ) Change subject: Add IPv6 support ...................................................................... Patch Set 2: (4 comments) File src/gtp-genl.c: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/b087f34e_d39e33cb PS2, Line 60: }
default: assert() Done
https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/c350bc50_b555d079 PS2, Line 69: }
default: assert() Done
https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/f1d30c8a_29d582ee PS2, Line 239: switch (pdp.ms_addr.family) {
All this can simply be: […] oh right, nice! :D
https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/38353512_cb43cd01 PS2, Line 249: switch (pdp.sgsn_addr.family) {
inet_ntop(pdp.sgsn_addr.family, &pdp.sgsn_addr. […] Done
-- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:43:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment