Attention is currently required from: jolly, dexter.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32930 )
Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions ......................................................................
Patch Set 2:
(8 comments)
File src/gsm/gsm44068.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326): https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/05f588df_0328ddfb PS2, Line 64: { OSMO_GSM44068_CAUSE_APP_NOT_SUPPORTED_ON_PROTO,"Application not supported on the protocol" }, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326): https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/291cbded_34f1a193 PS2, Line 71: { OSMO_GSM44068_CAUSE_NET_WANTS_TO_MAINTAIN_CALL,"Network wants to maintain call" }, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326): https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/e5dbe3b5_0e30d5fa PS2, Line 73: { OSMO_GSM44068_CAUSE_SERVICE_OPTION_NOT_SUBSCR,"Service option not supported" }, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326): https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/db87a087_bd0393da PS2, Line 74: { OSMO_GSM44068_CAUSE_REQUESTED_SERVICE_NOT_SUB,"Requested service option not subscribed" }, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326): https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/a568bf27_f1d08cc4 PS2, Line 76: { OSMO_GSM44068_CAUSE_CALL_CANNOT_BE_IDENTIFIED,"Call cannot be identified" }, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326): https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/a4966215_70bc7898 PS2, Line 77: { OSMO_GSM44068_CAUSE_RETRY_UPON_ENTRY_NEW_CALL,"retry upon entry into a new cell" }, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326): https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/1391d5ea_0c8c2622 PS2, Line 79: { OSMO_GSM44068_CAUSE_SEMANTICALLY_INCORRECT_MSG,"Semantically incorrect message" }, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326): https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/cbca1cd1_f11e9ab3 PS2, Line 81: { OSMO_GSM44068_CAUSE_MESSAGE_TYPE_NON_EXISTENT,"Message type non-existent or not implemented" }, space required after that ',' (ctx:VxV)