Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31769 to look at the new patch set (#2). Change subject: fix regression: unbreak PFCP: PS RAB via UPF proxying ...................................................................... fix regression: unbreak PFCP: PS RAB via UPF proxying Fix PS RAB Assignment operation: - add #include "config.h" - fix uncompilable code in ENABLE_PFCP sections. A series of oversights made me completely break PFCP / UPF operation for PS RAB Assignments in this commit: 'context map: introduce RUA and SCCP FSMs to fix leaks' ed424d5be471376d482d203c2e78deb1f836c119 I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 - In my HNBGW_Tests.ttcn, I used osmo-hnbgw-with-pfcp.cfg, but failed to set mp_enable_pfcp_tests := true in HNBGW_Tests.cfg. - Hence I was under the impression that I was testing PFCP via UPF when really I wasn't. So I did not notice that: - in the new files context_map_rua.c and context_map_sccp.c, the ENABLE_PFCP macro was always unset because I forgot to #include "config.h". - Hence I did not notice that the moved PFCP RAB code was never once compiled or run. My bad, that was really dumb. Related: SYS#6297 Change-Id: I5df5073f0092ecdfd73d5d08207ca4042154eab1 --- M src/osmo-hnbgw/context_map_rua.c M src/osmo-hnbgw/context_map_sccp.c M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_rua.c 4 files changed, 52 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/69/31769/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5df5073f0092ecdfd73d5d08207ca4042154eab1 Gerrit-Change-Number: 31769 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset