9 Oct
2026
9 Oct
'26
11:53 a.m.
Attention is currently required from: jolly, lynxis lazus.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43742?usp=email )
Change subject: Introduce osmo-remsim-client-socket ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/client/user_socket.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/43742/comment/0dac4e98_160c382b?u... : PS3, Line 57: LOGP(DMAIN, LOGL_INFO, "APDU response %s\n", osmo_hexdump(data, len)); APDUs are normal information that should't be logged unless DEBUG is enabled, IMHO
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43742?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I9eddb60e4e7c3191ca2b340690416b53005f714f
Gerrit-Change-Number: 43742
Gerrit-PatchSet: 3
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Fri, 09 Oct 2026 11:53:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes