lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42502?usp=email )
Change subject: rspro_server: use correct byte order in log message "Bankd IP/Port changed to <IP>:<Port> ......................................................................
rspro_server: use correct byte order in log message "Bankd IP/Port changed to <IP>:<Port>
The byte order is wrong and results in printing the IP as reverse. "Bankd IP/Port changed to 1.0.0.127:9999".
Change-Id: I288ea70091d24fa95732f7035ab50100831be841 --- M src/server/rspro_server.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/02/42502/1
diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 70d59c1..8e3cfe5 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -331,7 +331,7 @@
/* determine if IP/port of bankd have changed */ if (conn->client.bankd.port != bankd_port || conn->client.bankd.ip != bankd_ip) { - struct in_addr ia = { .s_addr = bankd_ip }; + struct in_addr ia = { .s_addr = htonl(bankd_ip) }; LOGPFSML(conn->fi, LOGL_NOTICE, "Bankd IP/Port changed to %s:%u\n", inet_ntoa(ia), bankd_port); conn->client.bankd.ip = bankd_ip; conn->client.bankd.port = bankd_port;