Attention is currently required from: fixeria, laforge, osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email )
Change subject: SIP_Emulation: Rename component id
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641/comment/9fffdd5e_7831…
PS1, Line 9: it makes it impossible to reference the
: component name under TESTPORT_PARAMETERS
This scaping of dashes through quotes looks more like a workaround placed after the name
was place, and imo makes everything more difficult for no good reason.
It's like putting spaces in files. Can be done? yes? Should we? No.
We follow this naming style in other testcases. so I
would suggest to stick to it.
I'm not aware we have a comprehensive guide on how to name components that we have to
follow :)
File library/SIP_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641/comment/bae8634e_d45f…
PS1, Line 229: _EMU
We also don't have the `EMU` in other emulation
components, so why making this different...
Why not? It's immediately informing
the component is SIP_Emulation, which really helps given that there's several
components containing the SIP word.
I have the feeling you are talking about current component names as if they were some sort
of conclusion after a long PhD investigation regarding optimum names, but the truth is
that most of them were just put without really thinking about good naming practices.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8
Gerrit-Change-Number: 36641
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Apr 2024 11:48:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment