Attention is currently required from: pespin, fixeria.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32926 )
Change subject: mgcp_codec: be sensitive about IuFP when checking codecs ......................................................................
Patch Set 2:
(2 comments)
File src/libosmo-mgcp/mgcp_codec.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/32926/comment/bc961e9e_5af891ea PS1, Line 336: /* In 3G IuUP AMR may be encapsulated in IuFP, this means even though the codec name and negotiated rate is
"In 3G IuUP, AMR" (missing comma).
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/32926/comment/77de8429_2295c28a PS1, Line 344: if (!iufp && strcmp(codec_a->subtype_name, codec_b->subtype_name))
this may be cleaner with a goto to line 346, instead of insturdicing the "iufp" flag. […]
Done