Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email )
Change subject: Rework SGSN code to use new libvlr code ......................................................................
Patch Set 22:
(4 comments)
File src/sgsn/sgsn_vty.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7c1e0f13_d1f42095?usp... : PS16, Line 806: /* FIXME: do we still have ACLs? */
what about this? afaiu in the commit message you said we removed it? Then all this needs to be depre […]
Moved the ACL removal commit into here.
https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/33490f37_27d14aad?usp... : PS16, Line 985: /* FIXME: reset VLR */
what about this?
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/63df856e_a81b561d?usp... : PS16, Line 1003: /* FIXME list VLR or MMctx */
what about this?
Done
File src/sgsn/sgsn_vty.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ed2028cb_40e0e512?usp... : PS20, Line 1088: if (pdp->pdp_address[0].u.sa.sa_family != AF_UNSPEC)
I'm totally lost here. […]
This commit never changed this, so this bugfix would be done in a separate commit.