Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 22: (4 comments) File src/sgsn/sgsn_vty.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7c1e0f13_d1f42095?usp... : PS16, Line 806: /* FIXME: do we still have ACLs? */
what about this? afaiu in the commit message you said we removed it? Then all this needs to be depre […] Moved the ACL removal commit into here.
https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/33490f37_27d14aad?usp... : PS16, Line 985: /* FIXME: reset VLR */
what about this? Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/63df856e_a81b561d?usp... : PS16, Line 1003: /* FIXME list VLR or MMctx */
what about this? Done
File src/sgsn/sgsn_vty.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ed2028cb_40e0e512?usp... : PS20, Line 1088: if (pdp->pdp_address[0].u.sa.sa_family != AF_UNSPEC)
I'm totally lost here. […] This commit never changed this, so this bugfix would be done in a separate commit.
-- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 22 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 06 Oct 2026 13:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>