dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32338 ) Change subject: e1d: maintain error log consistency in handle_ts_hdlc_read ...................................................................... e1d: maintain error log consistency in handle_ts_hdlc_read The function handle_ts_hdlc_read() should log read errors in the same way as the other functions do Change-Id: I0af06d6adcbf61e0996d9888feb70b74f0c9c0ef --- M src/input/e1d.c 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/input/e1d.c b/src/input/e1d.c index 289e693..56fb5e5 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -291,7 +291,7 @@ ret = read(bfd->fd, msg->data, TSX_ALLOC_SIZE); if (ret < 0) { - LOGPITS(e1i_ts, DLINP, LOGL_NOTICE, "read error %d %s\n", ret, strerror(errno)); + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "%s read error: %d %s\n", __func__, ret, strerror(errno)); msgb_free(msg); return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0af06d6adcbf61e0996d9888feb70b74f0c9c0ef Gerrit-Change-Number: 32338 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged