Attention is currently required from: laforge.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email )
Change subject: assignment_fsm: check ipaccess channel mode support ......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/assignment_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/42590/comment/21992dcf_aa3dcec5?usp=... : PS1, Line 375: const struct ipacc_supp_feat *feat =
might be prudent to add an OSMO_ASSERT on the correct BTS type here. […]
I can add an assert, but this is a static function that is currently used only once, and even if someone calls it for a non-ipaccess BTS nothing bad will happen: it will return `true` early because `!feat->present` will be `true` (because Supported Features IE was never received).