Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42502?usp=email )
Change subject: rspro_server: use correct byte order in log message "Bankd IP/Port changed to <IP>:<Port> ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/server/rspro_server.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42502/comment/624eb505_db857699?u... : PS1, Line 328: bankd_ip = ntohl(inet_addr(ip_str)); I wonder why are we actually storing conn->client.bankd.ip as a host-order buffer...
Maybe it makes sense to simply store it as network byte and use it that way everywhere?