Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42825?usp=email ) Change subject: stp: for TCAP loadshare: use NI == national ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1:
because International is encoded as 0 and we had this bug here which wasn't covered by tests: […] Ideally we should be using international and add a specific test to validate national, but since this only touched TCAP config file then I'm fine.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I51ef302ad72ff3c434fddb39006ce50106a5918f Gerrit-Change-Number: 42825 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Thu, 11 Jun 2026 20:20:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>