Attention is currently required from: pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40584?usp=email ) Change subject: Avoid reusing pending buffer; append incoming data instead ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40584/comment/2d06dcc3_18dae9f1?u... : PS1, Line 9: If there is pending data of an incomplete segmented message, received
Would you mind rewriting this? […] Done
File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40584/comment/c398a6f1_01d69cc7?u... : PS1, Line 303: msg_pending = iofd_msgb_alloc2(iofd, extra_len);
afaiu this is wrong. You are confusing the received_len with the size of the msgb. […] I changed the way the patch is working, so handling "extra_len" is not required anymore.
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I08df9736ccc5e9a7df61ca6dcf94629ee010752f Gerrit-Change-Number: 40584 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 21 Jul 2025 13:08:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>