Attention is currently required from: fixeria, neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email )
Change subject: osmo-upf: add VTY 'gtp-echo' command
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-upf/upf_vty.c:
https://gerrit.osmocom.org/c/osmo-upf/+/37830/comment/0fb42bf1_25e6b834?usp=... :
PS1, Line 491: tx to
I would write "[(a|b) ARG]" but it's a limitation of VTY that we need to write "[(a|b)] [ARG]"... […]
AFAICT, the latest version of the patch still doesn't use VTY_IPV46_CMD but re-defines this in every command. This is not how we do it in other places where we encounter the same situation (gb2, libosmo-sigtran, ...)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I970dccd7a27b098eea9e660822e24e2c4b059fc6
Gerrit-Change-Number: 37830
Gerrit-PatchSet: 3
Gerrit-Owner: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 23 Aug 2024 06:37:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
