9 Jun
2026
9 Jun
'26
3:20 p.m.
Attention is currently required from: Hoernchen, manawyrm.
pespin has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email )
Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Looks good to me as-is, but I would consider using `sbit_t` (self-explaining) or `int8_t`.
Agree with fixeria.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0
Gerrit-Change-Number: 42822
Gerrit-PatchSet: 1
Gerrit-Owner: manawyrm osmocom.account@tbspace.de
Gerrit-Reviewer: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Attention: manawyrm osmocom.account@tbspace.de
Gerrit-Comment-Date: Tue, 09 Jun 2026 15:20:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de