laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33360 ) Change subject: Cosmetic: gsm48_cc_tx_setup: remove TODO comment ...................................................................... Cosmetic: gsm48_cc_tx_setup: remove TODO comment Remove the comment as trans->bearer_cap will be used in CSD code to differentiate between speech and data. Related: OS#4394 Change-Id: I0539632f464bc44945599bec52dc2a4df2f0115f --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 9670db0..773ee3d 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -840,8 +840,6 @@ return rc; } /* Create a copy of the bearer capability in the transaction struct, so we can use this information later */ - /* TODO: we should be able to drop trans->bearer_cap, replaced by the codecs filter. Verify this. - * So far let's just store it there like previous code did. */ trans->bearer_cap = bearer_cap; /* If no resulting codecs remain, error out. We cannot find a codec that matches both call legs. If the MGW were * able to transcode, we could use non-identical codecs on each conn of the MGW endpoint, but we are aiming for -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0539632f464bc44945599bec52dc2a4df2f0115f Gerrit-Change-Number: 33360 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged