Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email ) Change subject: gen_makefile: support symlinks for src + src_proj ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File gen_makefile.py: https://gerrit.osmocom.org/c/osmo-dev/+/37888/comment/cb06ab35_f76cc00a?usp=... : PS1, Line 225: @if ! [ -e {src} ]; then \\ adding "/" to it ({src}/) may help with not accepting regular files? description from man test sounded like a regular file would pass this test here. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ic5ffa132b29e0a2ca78b02e4c8c05492471b3966 Gerrit-Change-Number: 37888 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes