19 Aug
2024
19 Aug
'24
10:57 a.m.
Attention is currently required from: laforge, neels.
pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email )
Change subject: pfcp-tool: n-sessions [1/4]: add generators for TEID and UE IP ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmo-pfcp-tool/pfcp_tool.h:
https://gerrit.osmocom.org/c/osmo-upf/+/37757/comment/7635f797_66790897?usp=... : PS2, Line 124: uint32_t pfcp_tool_new_teid(void); the field above is named next. The other field from the API below is also named next, and the API is also using the "next" keyword. Why is this using the "new" keyword instead?
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Iec164a222782d382aefe8d0342f398ebba1eac05
Gerrit-Change-Number: 37757
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Mon, 19 Aug 2024 08:57:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes