Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35775?usp=email ) Change subject: Delay deleting UL TBF until last Pkt Ctrl Ack is fully transmitted ...................................................................... Patch Set 4: (2 comments) File src/rlcmac/sched.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/35775/comment/0f5af12a_33b56b5e PS4, Line 162: TODO
please add the missing doc string Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/35775/comment/9b6abf1f_e68580e9 PS4, Line 216: //*tbf_to_free = ul_tbf_as_tbf(tbfs->poll_ul_ack);
Ack. Actually the whole "tbf_to_free" param can be dropped. Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35775?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic38b4207623ccbda3b77d4b0a47431c25de95034 Gerrit-Change-Number: 35775 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 15:01:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment