8 Oct
2026
8 Oct
'26
3:24 p.m.
Attention is currently required from: neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43513?usp=email )
Change subject: test_configurable_parameters.py: tweak logging ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File tests/unittests/xo/test_configurable_parameters:
https://gerrit.osmocom.org/c/pysim/+/43513/comment/77b89705_dbca950f?usp=ema... : PS2, Line 4: read_back_val={'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} Hmm. As far as I can see the changes here only change the formatting. If those changes are intentional and not an editor setting gone wild. I would recommend to put them in a separate patch.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43513?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I38e85ce0902f2ec4db63e158770b6d2cecb2dd30
Gerrit-Change-Number: 43513
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Thu, 08 Oct 2026 13:24:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes