dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 ) Change subject: mgw_fsm: release call when FSM is not created ...................................................................... mgw_fsm: release call when FSM is not created While the FSM is created the RAB Assignment Requests is checked and parsed. In case of failure the context is freed, but the CN is not informed about the problem. The RAB AssignmentRequest will then most likely time out. However, lets make sure the call is released by re requesting an IU Release. Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Related: OS#5152 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index d4ef800..3da2b60 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -719,9 +719,9 @@ return 0; error: - /* TODO: If we fail in this early stage, we should generate an appropriate RAB AssignmentResponse to inform - * the core network about the failure. */ + /* Cleanup context and make sure that the call is cleared. */ mgw_fsm_priv_cleanup(mgw_fsm_priv); + tx_release_req(map); return -EINVAL; } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Gerrit-Change-Number: 27320 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged