Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email )
Change subject: V1.2: Add TERMINAL CAPABILITY for IoT support ......................................................................
Patch Set 2:
(3 comments)
File src/ipa/libipa/euicc.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/2e81eb1f_2ed1fa42?... : PS1, Line 360: /* Send terminal capablilities, see also 3gpp TS 102.221 V16.2.0, section 11.1.19.2.4 */
I would change the section to 11.1. […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/e3a83f6c_f78e1c7b?... : PS1, Line 534: {
I think we should add a spec reference here: […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/9f439c41_dc9ecefa?... : PS1, Line 545: if (!ctx->cfg->iot_euicc_emu_enabled) {
I think we should pack termcap_euicc and termcap_iot into one TLV object and send it with a single T […]
Done