kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email ) Change subject: trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing ...................................................................... Patch Set 1: (2 comments) File src/target/trx_toolkit/data_msg.pyx: https://gerrit.osmocom.org/c/osmocom-bb/+/40078/comment/cc6fb76d_90adae90?us... : PS1, Line 397: # NOTE header lenght is already pre-checked by _parse_msg
'lenght' may be misspelled - perhaps 'length'?
Please fix. https://gerrit.osmocom.org/c/osmocom-bb/+/40078/comment/f685c27d_8b5f2926?us... : PS1, Line 710: # NOTE header lenght is already pre-checked by _parse_msg
'lenght' may be misspelled - perhaps 'length'?
Please fix. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I661a414bf5091fa6b872831ba911465a8d073397 Gerrit-Change-Number: 40078 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr@nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: osmith <osmith@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 15:33:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No