Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33788 ) Change subject: daemon_vty: avoid null-dereference in argc < 0 case ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-uecups/+/33788/comment/38cc67b5_79bea1b0 PS1, Line 10: which means in theory argc could be negative and the second clause
I think it's fine changing it to "argc > 0" to use same condition as above, but I doubt argc can be […] I'm not saying it is a realistic scenario. I'm saying it might happen theoretically. After all, it is a signed integer...
-- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/33788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I4149b0b191a34168ba6649338d3cdf6c6af6cfe7 Gerrit-Change-Number: 33788 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:17:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment