Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33308 ) Change subject: mgcp-client: Add keepalive feature ...................................................................... Patch Set 5: (1 comment) File include/osmocom/mgcp_client/mgcp_client_internal.h: https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/f9eab697_ccf0acd2 PS4, Line 22: conn_up
well, we really never know if they are UP, we just guess they are UP since they answered some time a […] well, the "answered some time ago" is true for any kind of availability checking. You never get information more precise than your "sample interval". Still, I think it's good practice to distinguish between "our keepalive mechanism has determine X or Y" and "we have never actually tried to even figure out".
All I want to prevent is some user looking at the vty output, relying that available actually means available, and then wasting time trying to debug a problem. You can keep the bool and just adjust the print-out, as I proposed further down this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3dc74c78548d017f272da863d5282dc5e0020ca3 Gerrit-Change-Number: 33308 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Jun 2023 09:45:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment