Attention is currently required from: daniel, lynxis lazus.
pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email )
Change subject: stp: Test TCAP routing with a different called address answering
......................................................................
Patch Set 1:
(1 comment)
File stp/STP_Tests_TCAP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682/comment/b12ab977_e549f... :
PS1, Line 275: OCT4 t_tid, integer alt_asp_idx := -1)
I think using `-1` is fine here. […]
numberings for all PC, routes etc. is already quite complex in these testsuites, adding more magic numbers like -1 here just makes it even harder.
This is clearly imho an optional parameter, and making it omit seems like the more obvious way to specify it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6d586b17b767219d20646f7cd1b59d6719cdbcdb
Gerrit-Change-Number: 42682
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Mon, 27 Apr 2026 16:18:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
