Attention is currently required from: fixeria, laforge, lynxis lazus, neels. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42662?usp=email ) Change subject: ts_51_011/EF.SMSP: fix handling of 'alpha_id' field ...................................................................... Patch Set 6: (1 comment) File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/42662/comment/9f1bde32_efe69d83?usp=ema... : PS5, Line 344: self._construct = Struct('alpha_id'/GsmOrUcs2Adapter(Rpad(Bytes(this._.total_len-28))),
maybe add a short comment about COptional can't be used, see comment below. I guess that means that you share my opinion here.
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/42662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0ec99b2648b22c56f9145345e4cd8776f9217701 Gerrit-Change-Number: 42662 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 09:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu> Comment-In-Reply-To: dexter <pmaier@sysmocom.de>