Attention is currently required from: Hoernchen, fixeria.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43200?usp=email )
Change subject: GP: fix kcb for non block aligned keys ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Patchset:
PS6: I have now looked through this carefully. Everything seems to be correct. I guess the reason why we had no problems putting AES/DES keys so far was because their length are block aligned (no padding required). I guess the problem came up with the SCP81 PSK keys...
One hint: I think it is always best to write out the full spec reference, like "see also GPC table 11-70" or "see also GlobalPlatform Card Specification, table 11-70". The reason why I suggest this is because it is not uncommon to reference to different specs from the same module. Also for its much harder for someone who is not that deep into the matter to immediately know which spec is ment. In any case, this is only a suggestion based on a personal preference. You don't have to adopt it if you do not see the benefit.