Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email )
Change subject: erab_fsm: Abort and reply call with error if unable to establish PFCP sess ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File src/erab_fsm.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/f2d4cf4c_2094d... : PS1, Line 176: next_state, ?FUNCTION_NAME, S, %% loop transition to enable state_timeout Why are you removing the loop transition? I think I already explained somewhere that the `state_timeout` is ignored when doing `keep_state`, so the `next_state` here for a reason (as the comment explains).
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/87f60f97_88102... : PS1, Line 181: timeout How do you know that it's specifically a timeout?