Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email ) Change subject: Use new libosmo-sigtran API osmo_ss7_instance_get_id() ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/38650/comment/74f4a532_4aa3be0a?usp=... : PS1, Line 9: Change-IdChange-Id
`Change-Id` twice. […] To me it's clearer. It's easy to confuse the I at the start as part of the hash, plus some people may not know about Change-Id (gerrit) so it's better to state it there imho. At least I tend to do it when I submit stuff.
-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0a468de0e8852ddd1ebd99f25a6400475af9a1f Gerrit-Change-Number: 38650 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:53:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>