Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43566?usp=email )
Change subject: contrib: add scp81 OTA trigger builder ......................................................................
Patch Set 3: Code-Review+1 Verified+1
(3 comments)
Patchset:
PS3: I have tried it (only generating the API, I didn't sent it to a card), seems to work fine.
File contrib/scp81_trigger.py:
https://gerrit.osmocom.org/c/pysim/+/43566/comment/bf1113ed_f8248a44?usp=ema... : PS3, Line 1: #!/usr/bin/env python3 As it seems the execution bit is not set on this file.
https://gerrit.osmocom.org/c/pysim/+/43566/comment/6ba49438_ecca2576?usp=ema... : PS3, Line 50: ap.add_argument("--psk-id", help="PSK identity for ClientHello (required unless --no-sec)") missing comma: (required, unless ...)