Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43652?usp=email )
Change subject: Add index to ipa_es10b_get_eim_cfg_data_filter ......................................................................
Patch Set 3:
(3 comments)
File src/ipa/libipa/es10b_get_eim_cfg_data.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/8c830078_1494b03c?... : PS2, Line 297:
maybe set *eim_cfg_data_item = NULL; for good measure?
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/dff204ab_6ebb13ec?... : PS2, Line 309: /* In case no eim_id is specified, just pick the item from the list that is specified by index */
Maybe rephrase the comment a bit? […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/3b2aea46_37ecf1ff?... : PS2, Line 317:
Maybe add a comment? […]
Done