Attention is currently required from: falconia.
laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42729?usp=email )
Change subject: nokia: rename BTS model from nokia_site to nokia-e1 ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: I think this is probably an unneccessary change, and one thet will be reverted if and when you ever support the IP based nokia abis. In the end, a lot of the nokia specific code is about specifics of the nokia bts hardware, and not specifics of the protocol used to talk to that hardware.
So you could just keep it at the current slightly incorrect/outdated name, instead of introducing something that is very likely also incorrect as we currently have no separation between "nokia BTS type" and "protocol used to talk to nokia BTS".