Attention is currently required from: laforge.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42838?usp=email )
Change subject: server: fix misleading data length validation log message ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcap/+/42838/comment/1010297c_2c4dcde9?usp... : PS1, Line 9: The format string "%u < %u <= %u" was printed with arguments : (min_len, data->len, max_len), placing the offending length in : the middle and mislabeling it. This is confusing. Let's print : the actual length followed by the expected interval instead.
Hm, I actually think it's quite obvious the way it was. […]
I do not insist on merging this patch, but I find the current error message confusing. It says "Implausible data length" and then gives the expected value boundaries, that are not 100% accurate. Specifically, the min length `%u < %u` - it should actually be `%u <= %u`.