Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43549?usp=email )
Change subject: osmo-smdpp: add --smdp-address to set ES9+ SM-DP+ address ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/43549/comment/1197eb9c_9abf5146?usp=ema... : PS2, Line 18: so this is useful for debugging, but likely not spec compliant. To my opinion this is an error in the spec. If we would apply this strictly, it would be impossible to operate an SM-DP+ on any other port than 443.
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/43549/comment/7750f086_222e643d?usp=ema... : PS2, Line 923: "The TLS cert identity is unaffected. Useful for debugging.") I would remove "HOSTNAME" from the help text. This this is a constant in the code and not relevant for the user. Users may even think that this would refer to the environment variable $HOSTNAME - just write "... defaults to "%(default)s". "
also don't forget to add a space after the dot. I would also recommend to remove the "Useful for debugging". I think this useful in general.